Merge pull request #566 from chinapandaman/PPF-565

PPF-565: cleanup PPF-561
chinapandaman · Apr 14, 2024 · 9b6421f · 9b6421f
2 parents b15c319 + a3539e9
commit 9b6421f
Show file tree

Hide file tree

Showing 22 changed files with 33 additions and 0 deletions.
diff --git a/PyPDFForm/patterns.py b/PyPDFForm/patterns.py
@@ -96,6 +96,7 @@ def simple_update_radio_value(annot: DictionaryObject) -> None:
     for each in annot[AP][D]:  # noqa
         if str(each) != Off:
             annot[NameObject(AS)] = NameObject(each)
+            annot[NameObject(Parent)][NameObject(V)] = NameObject(each) # noqa
             break
 
 

diff --git a/pdf_samples/scenario/issues/PPF-415-3-expected.pdf b/pdf_samples/scenario/issues/PPF-415-3-expected.pdf
diff --git a/pdf_samples/scenario/issues/PPF-415-expected.pdf b/pdf_samples/scenario/issues/PPF-415-expected.pdf
diff --git a/pdf_samples/simple/dropdown/dropdown_four.pdf b/pdf_samples/simple/dropdown/dropdown_four.pdf
diff --git a/pdf_samples/simple/dropdown/dropdown_one.pdf b/pdf_samples/simple/dropdown/dropdown_one.pdf
diff --git a/pdf_samples/simple/dropdown/dropdown_three.pdf b/pdf_samples/simple/dropdown/dropdown_three.pdf
diff --git a/pdf_samples/simple/dropdown/dropdown_two.pdf b/pdf_samples/simple/dropdown/dropdown_two.pdf
diff --git a/pdf_samples/simple/dropdown/dropdown_two_simple.pdf b/pdf_samples/simple/dropdown/dropdown_two_simple.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/comb_text_field_all_chars.pdf b/pdf_samples/simple/max_length_text_field_related/comb_text_field_all_chars.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/comb_text_field_even_chars.pdf b/pdf_samples/simple/max_length_text_field_related/comb_text_field_even_chars.pdf
diff --git a/...samples/simple/max_length_text_field_related/comb_text_field_even_chars_right_aligned.pdf b/...samples/simple/max_length_text_field_related/comb_text_field_even_chars_right_aligned.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/comb_text_field_odd_chars.pdf b/pdf_samples/simple/max_length_text_field_related/comb_text_field_odd_chars.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/max_length_text_field_all_chars.pdf b/pdf_samples/simple/max_length_text_field_related/max_length_text_field_all_chars.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/max_length_text_field_even_chars.pdf b/pdf_samples/simple/max_length_text_field_related/max_length_text_field_even_chars.pdf
diff --git a/pdf_samples/simple/max_length_text_field_related/max_length_text_field_odd_chars.pdf b/pdf_samples/simple/max_length_text_field_related/max_length_text_field_odd_chars.pdf
diff --git a/pdf_samples/simple/paragraph/sample_filled_sejda_complex.pdf b/pdf_samples/simple/paragraph/sample_filled_sejda_complex.pdf
diff --git a/pdf_samples/simple/paragraph/sample_filled_sejda_complex_flatten.pdf b/pdf_samples/simple/paragraph/sample_filled_sejda_complex_flatten.pdf
diff --git a/pdf_samples/simple/sample_filled_radiobutton.pdf b/pdf_samples/simple/sample_filled_radiobutton.pdf
diff --git a/pdf_samples/simple/sample_filled_sejda.pdf b/pdf_samples/simple/sample_filled_sejda.pdf
diff --git a/pdf_samples/simple/scenario/tools/docfly_expected.pdf b/pdf_samples/simple/scenario/tools/docfly_expected.pdf
diff --git a/pdf_samples/simple/scenario/tools/pdf_escape_expected.pdf b/pdf_samples/simple/scenario/tools/pdf_escape_expected.pdf
diff --git a/tests/scenario/test_issues.py b/tests/scenario/test_issues.py
@@ -42,6 +42,22 @@ def test_pdf_form_with_central_aligned_text_fields_void(issue_pdf_directory):
     assert PdfWrapper(os.path.join(issue_pdf_directory, "PPF-285.pdf")).fill({}).read()
 
 
+def test_pdf_form_with_paragraph_fields_new_line_symbol_text(
+    issue_pdf_directory, request
+):
+    obj = PdfWrapper(os.path.join(issue_pdf_directory, "PPF-415.pdf")).fill(
+        {"Address": "Mr John Smith\n132, My Street\nKingston, New York 12401"}
+    )
+
+    expected_path = os.path.join(issue_pdf_directory, "PPF-415-expected.pdf")
+    request.config.results["expected_path"] = expected_path
+    request.config.results["stream"] = obj.read()
+    with open(expected_path, "rb+") as f:
+        expected = f.read()
+        if os.name != "nt":
+            assert abs(len(obj.read()) - len(expected)) <= 1
+
+
 def test_pdf_form_with_paragraph_fields_new_line_symbol_text_overflow(
     issue_pdf_directory, request
 ):
@@ -80,6 +96,22 @@ def test_521(issue_pdf_directory, request):
         assert obj.stream == expected
 
 
+def test_pdf_form_with_paragraph_fields_new_line_symbol_short_text(
+    issue_pdf_directory, request
+):
+    obj = PdfWrapper(os.path.join(issue_pdf_directory, "PPF-415.pdf")).fill(
+        {"Address": "J Smith\n132 A St\nNYC, NY 12401"}
+    )
+
+    expected_path = os.path.join(issue_pdf_directory, "PPF-415-3-expected.pdf")
+    request.config.results["expected_path"] = expected_path
+    request.config.results["stream"] = obj.read()
+    with open(expected_path, "rb+") as f:
+        expected = f.read()
+        if os.name != "nt":
+            assert abs(len(obj.read()) - len(expected)) <= 1
+
+
 def test_encrypted_edit_pdf_form(issue_pdf_directory, request):
     obj = PdfWrapper(os.path.join(issue_pdf_directory, "437.pdf"))
     obj = obj.fill(obj.sample_data)