Merge pull request #685 from chinapandaman/PPF-684

PPF-684: fix the pattern that detects sejda checkbox

PyPDFForm/constants.py

@@ -32,8 +32,6 @@
 JS = "/JS"
 T = "/T"
 Rect = "/Rect"
-Subtype = "/Subtype"
-Widget = "/Widget"
 FT = "/FT"
 Parent = "/Parent"
 Ff = "/Ff"
@@ -43,6 +41,7 @@
 N = "/N"
 Sig = "/Sig"
 DA = "/DA"
+DV = "/DV"
 Btn = "/Btn"
 MaxLen = "/MaxLen"
 Q = "/Q"

PyPDFForm/patterns.py

@@ -6,7 +6,7 @@
 
 from .constants import (AP, AS, CA, DA, FT, IMAGE_FIELD_IDENTIFIER, JS, MK,
                         READ_ONLY, A, Btn, Ch, Ff, N, Off, Opt, Parent, Q, Sig,
-                        Subtype, T, Tx, V, Widget, Yes)
+                        DV, T, Tx, V, Yes)
 from .middleware.checkbox import Checkbox
 from .middleware.dropdown import Dropdown
 from .middleware.image import Image
@@ -49,7 +49,7 @@
     (
         (
             {Parent: {FT: Btn}},
-            {Parent: {Subtype: Widget}},
+            {Parent: {DV: (Yes, Off)}},
             {AS: (Yes, Off)},
         ),
         Checkbox,

tests/scenario/test_issues.py

@@ -212,3 +212,17 @@ def test_ppf_627_fill_3(issue_pdf_directory, request):
         expected = f.read()
         assert len(obj.read()) == len(expected)
         assert obj.read() == expected
+
+
+def test_sejda_checkbox(issue_pdf_directory, request):
+    obj = PdfWrapper(os.path.join(issue_pdf_directory, "683.pdf")).fill(
+        {"test_checkbox": True}
+    )
+
+    expected_path = os.path.join(issue_pdf_directory, "683_expected.pdf")
+    request.config.results["expected_path"] = expected_path
+    request.config.results["stream"] = obj.read()
+    with open(expected_path, "rb+") as f:
+        expected = f.read()
+        assert len(obj.read()) == len(expected)
+        assert obj.read() == expected