Add extra div cutoffs and substantial refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd API and GameInfo classes
also fix bug wrt showing `belowdiv` when there aren't enough players
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted some more divs to show in COTDStats, here's the draft implementation.
I also did a substantial refactor of API calls and "GameInfo" stuff.
If this is something you'd consider merging, I'm happy to polish things up and whatever to bring it in line with what you'd like.
Here's a low quality screenshot of both of them to give you an idea of the changes (note: there's a bug with the div6 time b/c it wasn't full)
Additional stuff:
todos (incomplete list)