Skip to content

Style split figure captions#1477

Merged
stefan-burke merged 2 commits into
mainfrom
style/split-figure-captions
Jul 20, 2026
Merged

Style split figure captions#1477
stefan-burke merged 2 commits into
mainfrom
style/split-figure-captions

Conversation

@stefan-burke

@stefan-burke stefan-burke commented Jul 19, 2026

Copy link
Copy Markdown
Member

Summary

  • add compact padding to split figure captions
  • use small italic text with a section-aware card background
  • preserve caption contrast in dark sections

Testing

  • bun test test/unit/build/scss.test.js
  • bun test/precommit.js

Summary by CodeRabbit

  • Style
    • Improved split-layout figure captions with added padding, smaller italic text, and a card-style background for better visual consistency.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added figcaption styling to design-system split figures, including padding, small italic typography, and the card background color.

Changes

Split caption styling

Layer / File(s) Summary
Figure caption presentation
src/css/design-system/_split.scss
Adds padding, small italic typography, and var(--color-card-bg) styling to captions within split figures.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding caption styling for split figures.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch style/split-figure-captions

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfa55282a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/css/design-system/_split.scss Outdated
@stefan-burke
stefan-burke added this pull request to the merge queue Jul 20, 2026
Merged via the queue into main with commit 6336b4c Jul 20, 2026
5 checks passed
@stefan-burke
stefan-burke deleted the style/split-figure-captions branch July 20, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant