Replace join page enrolment iframe with a link button - #2
Merged
Conversation
The AdminMyMembers enrolment form was embedded in a 900px iframe on the join page. Swap it for the design system's link-button block pointing at https://s-gfc.ammhub.com/, keeping the "Enrol online" heading and intro copy in a markdown block above it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CT9ttUYnPUmHyghh5U6T7G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the embedded AdminMyMembers enrolment form on
/join/for a link out to https://s-gfc.ammhub.com/.Changes
pages/join.md— theiframe-embedblock (900px tall,src: https://s-gfc.ammhub.com/) is replaced by two blocks:markdownblock carrying the existing "Enrol online" heading and intro copy, reworded from "the secure membership form below" since the form is no longer on the pagelink-buttonblock (size: lg, defaultprimaryvariant) linking to https://s-gfc.ammhub.com/Both are
compact: trueso they sit close together, matching the section spacing used elsewhere on the page.link-buttonrenders a centred standalone button and takes no intro content of its own, which is why the heading and copy live in a separatemarkdownblock above it. If the heading isn't wanted, dropping that first block leaves just the button.Verification
Built locally against the template revision CI uses (
chobble-template@main) and screenshotted/join/at desktop and mobile widths — the button renders as<a href="https://s-gfc.ammhub.com/" class="btn btn--primary btn--lg">Start your enrolment</a>inside.link-button, and no<iframe>remains on the page.The build reports a failure on an unrelated page: the home page's
split-videoblock can't fetch its YouTube thumbnail from this sandbox's network. That's pre-existing and unaffected by this change.Generated by Claude Code