Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1028) Update icons with font awesome accesibility approach #1076

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

LeaDevelop
Copy link
Contributor

@LeaDevelop LeaDevelop commented Oct 6, 2024

Description Of Changes

Unicode emoticons (⚙💾🔍➕📅🗑) replaced with font awesome accessibility ones.

Motivation and Context

Motivation was to improve the user experience and ensure consistent visual representation across different platforms and devices. Previously, emoticons were not considering accessibility, which could lead to confusion or misinterpretation of the documentation when using screen reader.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Pages that were validated:

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

@LeaDevelop LeaDevelop marked this pull request as ready for review October 7, 2024 00:00
@st3phhays st3phhays self-requested a review October 7, 2024 15:08
@st3phhays
Copy link
Member

Hey @LeaDevelop thanks for the PR!

We may need to make some informed decisions on which of these to keep and which icons to remove completely. I will post a review with suggestions when we start our focus on accessibility in the coming weeks.

@LeaDevelop
Copy link
Contributor Author

Sounds like a plan 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants