Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) choco install update packages.config params #1085

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stunkymonkey
Copy link

Description Of Changes

some parameters are not documented. taken from https://github.com/chocolatey/choco/blob/develop/src/chocolatey/infrastructure.app/configuration/PackagesConfigFilePackageSetting.cs

Motivation and Context

Users should not have to read code.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

N/A

@pauby
Copy link
Member

pauby commented Oct 16, 2024

Can you fix the PR so only the changes show? If you are making whitespace changes, please use a separate commit.

@pauby pauby added the 0 - Waiting on User Insufficient information for issue or PR, issue may be closed if no response from user label Oct 17, 2024
@Stunkymonkey Stunkymonkey force-pushed the add-missing-packages.config-param branch from 80af8a9 to a230cce Compare October 17, 2024 19:49
@Stunkymonkey
Copy link
Author

@pauby sure. is this better? (this was automatically applied editor-config)

@Stunkymonkey Stunkymonkey force-pushed the add-missing-packages.config-param branch from a230cce to e36ed1d Compare October 22, 2024 18:44
@Stunkymonkey
Copy link
Author

ping @pauby

Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This pull request will be closed in 14 days if it continues to be inactive.

@github-actions github-actions bot added the Pending Closure This issue has been marked as having no response or is stale and will soon be closed. label Dec 11, 2024
@pauby
Copy link
Member

pauby commented Dec 11, 2024

@Stunkymonkey this isnt any different. This shows you have removed 559 lines and added 595. See the Files changed tab.

@AdmiringWorm @gep13 could this be down to line endings? What is normally done in this situation to allow the actual changes to be seen?

@AdmiringWorm
Copy link
Member

@AdmiringWorm @gep13 could this be down to line endings? What is normally done in this situation to allow the actual changes to be seen?

It is highly likely due to line endings, yes, and most likely caused by what is set as the core.autocrlf settings for git. (This setting should normally be set to false for our repositories, but can be set to input for this repository).

Normally in this situation, we ask that the one that opened the PR to revert the changes to the line endings (or we make the change in some cases), but it can depend on a couple of things.

  1. If the line endings are changed to be fixed, then that should be a separate commit.
  2. Or if the line endings are incorrect, update the setting I mentioned before, change the line endings again and commit the file in the same commit).

I am not sure what is the case for this PR.

@Stunkymonkey
Copy link
Author

Hey @pauby and @AdmiringWorm

this is related to the line-endings. this is why I separated it into a separate commit (see 0ca6ec9), so it is easier for you to review.

I am confused. why is the .editorconfig located in this repo if it is enforce to not use it..?

@github-actions github-actions bot removed Pending Closure This issue has been marked as having no response or is stale and will soon be closed. 0 - Waiting on User Insufficient information for issue or PR, issue may be closed if no response from user labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants