backport build_image.yml to main#439
Merged
evaneschneider merged 3 commits intocholla-hydro:mainfrom Aug 18, 2025
Merged
Conversation
Without doing this all PRs to the main branch will fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can't trigger the build_image.yml workflow right now. I think the way to fix this is to backport this workflow to the main branch. (I mentioned that this might be necessary back in #438)
EDIT: I also backported .pre-commit-config.yaml from dev (I chose a slightly earlier version that won't trigger any changes in this branch). This ensures that that the pre-commit.ci checks won't fail
EDIT2: I needed to bump the version of the rocm dockerfile that is pull from dockerhub (it seems like there is an issue with the old dockerfile)