Draft: Descriptor support to enable taproot wallets #271
Draft
rage-proof wants to merge 8 commits intochris-belcher:masterfrom
Draft
Draft: Descriptor support to enable taproot wallets #271rage-proof wants to merge 8 commits intochris-belcher:masterfrom
rage-proof wants to merge 8 commits intochris-belcher:masterfrom
Conversation
added 8 commits
May 23, 2022 12:17
This make it possible to import descriptors including taproot(tr). Some other functions don't work anymore with the new wallet, e.g. import addresses, is_wachonly. Hence use replacement functions in those cases.
…y are used for xpubs. Therefore remove the label also form the imported single addresses.
chris-belcher
force-pushed
the
master
branch
4 times, most recently
from
0633d2c to
c28a90f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just wanted to add add the descriptor and taproot support for eps.
But then it let to more changes as intended that were needed. So I let this PR here and you can use it for later, because it works.
The problem is the legacy wallet is not able to handle taproot addresses.
wallet options:
legacy(berkley) - no
importdescriptors, no taproot-addresses in generalnew(sqlite) - no
importmulti, noimportaddressesThis leads to the conclusion that the use of the new-descriptor wallet is mandatory and comes with some obstacles:
Because of having a current version of Core + creating a new wallet it's a bit much effort for an update.
Maybe the rpc
upgradewalletis an option to keep the effort low.