Skip to content

Fix build errors in Qt 6.8.2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

RomanPodymov
Copy link

Hello.
Thank you for burger-menu.
Fix build errors.


class BurgerButton : public QPushButton
{
Q_OBJECT
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisaverage Looks like there must be Q_OBJECT, then BurgerButton must be declared in a header file.

@chrisaverage
Copy link
Owner

Thank you for contributing, but BurgerButton class is an implementation detail and I don't want to expose it in the public header.
I've just pushed an update to address Qt 6.8 issue, as well as some compilation warnings that piled up over the years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants