Skip to content

Make List() return []*Group instead of unparsed strings #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willglynn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make List() return []*Group instead of unparsed strings #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nntp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ func (c *Conn) Date() (time.Time, error) {
// List(keyword) - return different kinds of information about groups
// List(keyword, pattern) - filter groups against a glob-like pattern called a wildmat
//
func (c *Conn) List(a ...string) ([]string, error) {
func (c *Conn) List(a ...string) ([]*Group, error) {
if len(a) > 2 {
return nil, ProtocolError("List only takes up to 2 arguments")
}
Expand All @@ -492,7 +492,7 @@ func (c *Conn) List(a ...string) ([]string, error) {
if _, _, err := c.cmd(215, cmd); err != nil {
return nil, err
}
return c.readStrings()
return c.readGroups()
}

// Group changes the current group.
Expand Down