No need to split dimension/metic values on a colon #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. This was causing a bug whenever a value contained a colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked down an issue I was having where URLs which contained a colon character were not being properly included in the Gattica results. For example, this crazy URL from our Google Analytics account:
/stories/Rida-Asim-Wins-Scholastic-Regional-Art-and-Writing-Award/209582?fb_action_ids=10151390356368347&fb_action_types=og.likes&fb_source=other_multiline&action_object_map={"10151390356368347":524248140960991}&action_type_map={"10151390356368347":"og.likes"}&action_ref_map=[]
...was being returned as: "og.likes"}&action_ref_map=[]
This was due to the following line in the DataPoint model's initializer:
{ dimension.attributes['name'].split(':').last.to_sym => dimension.attributes['value'].split(':').last }
I understand why you are splitting the dimension/metic names on a colon but I do not believe that you have to split the values. For example you would want to split the name ga:pagePath to get pagePath but not the value: /foo/bar?baz=123. Let me know if I'm wrong about this.