TKT-022: Run full test suite on PRs, not just smoke — prevent broken main#1056
Open
chrismcdermut wants to merge 2 commits intomainfrom
Open
TKT-022: Run full test suite on PRs, not just smoke — prevent broken main#1056chrismcdermut wants to merge 2 commits intomainfrom
chrismcdermut wants to merge 2 commits intomainfrom
Conversation
…guidance, PreToolUse hook
…ook, prompt guidance, script validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves TKT-022: Run full test suite on PRs, not just smoke — prevent broken main
Description
Problem
PR CI only runs smoke tier (
e2e-tests (22, smoke)). Post-merge CI runs full suite (7 shards: pmo, execution, agent-flows, json-mode, integrations, standalone, infrastructure).This means test failures can land on main undetected. We just had 17 tests break on main from merged PRs that passed PR CI.
Solution
Run full test suite on PRs, not just smoke. Options to keep it fast:
Option A: Full suite on all PRs
Option B: Full suite on merge (merge queue)
Option C: Full suite on PRs touching test-adjacent files
Recommendation
Option A is simplest. CI is already ~5 min for smoke. Full suite adds ~3 min. Total ~8 min is acceptable.
Files
External Issue Context
Changes
Test Plan