Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical scrollbar option #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PatrickSBradley
Copy link

Chris,

I discovered that i had the spaces\tabs settings in visual studio set to spaces and that was causing all kinds of diffs in the files I had changed. So I switched to tabs and now things look much better.

Added a vertical scroll option to the carousel. By default, the behavior has not changed(horizontal scroll) but now the user can switch to vertical scroll if they want to.

Pat Bradley

@entdark
Copy link

entdark commented Apr 22, 2016

I think you should make a parameter with a default value set in the constructor so it won't break compatibility.
cf2950a#diff-b332fd4efebb1d290e3cde7040afe3acR24

@PatrickSBradley
Copy link
Author

thanks, i missed that and wll do it.

On Fri, Apr 22, 2016 at 3:34 AM, entdark [email protected] wrote:

I think you should make a parameter with a default value set in the
constructor so it won't break compatibility.
cf2950a#diff-b332fd4efebb1d290e3cde7040afe3acR24
cf2950a#diff-b332fd4efebb1d290e3cde7040afe3acR24


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#19 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants