Fixed an issue on android where carousel would snap to a page prematurly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikeredbit - Thanks for contributing back :) Sorry it's been so long for me to respond. Do you happen to remember the use-case that you were running into where this was an issue? The issue wasn't immediately obvious to me, so I'm just trying to learn/understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HorizontalScrollView's MotionEventActions.Down event was never firing, possibly due to a child element consuming the event. I've added a call to OnMotionEventActionsDown() at the beginning of the Move event's case block that will fire the down event's code only if _motionDown is false. This will ensure that the down event's code gets executed.