Skip to content

Handle the PROPFIND w/ empty/missing request body case #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle the PROPFIND w/ empty/missing request body case #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29840d
Controller#propfind: Handle the empty request body case.
inferiorhumanorgans Aug 26, 2013
f5378f4
Controller#propfind: Update to 14502d23d3 handle missing content-length.
inferiorhumanorgans Sep 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/dav4rack/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ def propfind
unless(resource.exist?)
NotFound
else
unless(request_document.xpath("//#{ns}propfind/#{ns}allprop").empty?)
# Per RFC 2518 §8.1
# An empty PROPFIND request body must be treated as a request for the names and values of all properties.
if !request_document.xpath("//#{ns}propfind/#{ns}allprop").empty? or (request.content_length == '0') or (request.content_length.nil?)
properties = resource.properties
else
check = request_document.xpath("//#{ns}propfind")
Expand Down