Expensereport java refactored

[Ashish-CodeJourney]

This is something i did while considering some points from Working with legacy code by michael c. feathers

I am basically learning more about SOLID principals
I know the meaning but i don't have that much of experience on large applications or how to these thing affects a big Application
also i am using cucumber for the first time.

used some AI tools as well (no, not chatGPT but Amazon Q and Continue)
as trying my hands on JAVA after a Long time.

I am also trying to collect some people with whom i can practice Pair Programming on daily basis
not just for job but for mastering some skills.

@christianhujer it was a very Insightful experience.
Please give it a review, suggestions will be appreciated.

[christianhujer]

I appreciate the attempt of providing a solution to the solution branch. However, this solution is not in line with the general way of refactoring the code. The code smells anaemic class, OCP violation, and SRP violation are not solved. Ultimately, (almost) all switch and if statements should be replaced with some form of polymorphism. There are language features like enums as real classes, and records, that could and should be used in a Java refactoring of this piece of code.