feat: elax parse ticket in pr title and add status

christophehurpeau · Oct 4, 2024 · 0c23252 · 0c23252
1 parent 2c10c7b
commit 0c23252
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 4 deletions.
diff --git a/src/accountConfigs/Elax-Energie.ts b/src/accountConfigs/Elax-Energie.ts
@@ -12,7 +12,47 @@ const config: Config<never> = {
     deleteAfterMerge: true,
   },
   parsePR: {
-    title: [],
+    title: [
+      {
+        regExp: /\s([A-Z][\dA-Z]+-(\d+)|\[no issue])$/,
+        status: "notion-ticket",
+        createStatusInfo: (match, prInfo, isPrFromBot) => {
+          if (match) {
+            const ticket = match[1];
+            if (ticket === "[no ticket]") {
+              return {
+                type: "success",
+                title: "✓ No ticket",
+                summary: "",
+              };
+            }
+
+            const url = `https://www.notion.so/elaxenergie/${ticket}`;
+            return {
+              type: "success",
+              inBody: true,
+              title: `✓ Notion ticket: ${ticket}`,
+              summary: `[${ticket}](${url})`,
+              url,
+            };
+          }
+
+          if (isPrFromBot) {
+            return {
+              type: "success",
+              title: "Title does not have Notion ticket but PR created by bot",
+              summary: "",
+            };
+          }
+
+          return {
+            type: "failure",
+            title: "Title does not have Notion ticket",
+            summary: "The PR title should end with GEN-0000, or [no ticket]",
+          };
+        },
+      },
+    ],
     body: [
       {
         bot: false,
@@ -30,7 +70,7 @@ const config: Config<never> = {
             .replace(/^\s*#+\s+.*/gm, "")
             .replace(/(<!--.*?-->)|(<!--[\S\s]+?-->)|(<!--[\S\s]*?$)/gs, "");
 
-          if (!descriptionStripTitlesAndComments?.trim()) {
+          if (!descriptionStripTitlesAndComments.trim()) {
             return {
               type: "failure",
               title: "Body has no meaningful content",

diff --git a/src/events/pr-handlers/actions/utils/prTitle.test.ts b/src/events/pr-handlers/actions/utils/prTitle.test.ts
@@ -107,5 +107,8 @@ describe("cleanTitle", () => {
     expect(cleanTitle("feat: add something - [no-issue]", true)).toBe(
       "feat: add something [no issue]",
     );
+    expect(cleanTitle("feat: add something - [no-ticket]", true)).toBe(
+      "feat: add something [no ticket]",
+    );
   });
 });
diff --git a/src/events/pr-handlers/actions/utils/prTitle.ts b/src/events/pr-handlers/actions/utils/prTitle.ts
@@ -21,7 +21,8 @@ export const cleanTitle = (
     )
     .replace(/^([A-Za-z]+)[/:;]\s*/, (s, arg1) => `${arg1.toLowerCase()}: `)
     .replace(/\s+(-\s*)?[()[\]]\s*no[\s-]*isss?ue\s*[()[\]]$/i, " [no issue]")
-    .replace(/^Revert "([^"]+)"( \[no issue])?$/, "revert: $1$2")
-    .replace(/^(revert:.*)(\s+\(#\d+\))( \[no issue])?$/, "$1$3")
+    .replace(/\s+(-\s*)?[()[\]]\s*no[\s-]*ticket\s*[()[\]]$/i, " [no ticket]")
+    .replace(/^Revert "([^"]+)"( \[no (issue|ticket)])?$/, "revert: $1$2")
+    .replace(/^(revert:.*)(\s+\(#\d+\))( \[no (issue|ticket)])?$/, "$1$3")
     .replace(/^(?:revert: ){2}/, "");
 };