Add missing override annotations (#164)

chrisvest · Jun 2, 2024 · f1a02ac · f1a02ac
2 parents 95ae482 + 9328b48
commit f1a02ac
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 4 deletions.
diff --git a/src/main/java/stormpot/BSlot.java b/src/main/java/stormpot/BSlot.java
@@ -39,7 +39,8 @@ final class BSlot<T extends Poolable>
     // threads observe the pointer to this object.
     super(DEAD, live, poisonedSlots);
   }
-
+
+  @Override
   public void release(Poolable obj) {
     if (poison == BlazePool.EXPLICIT_EXPIRE_POISON) {
       poisonedSlots.getAndIncrement();

diff --git a/src/main/java/stormpot/LatchCompletion.java b/src/main/java/stormpot/LatchCompletion.java
@@ -24,7 +24,8 @@ final class LatchCompletion implements Completion {
   LatchCompletion(CountDownLatch completionLatch) {
     this.completionLatch = completionLatch;
   }
-
+
+  @Override
   public boolean await(Timeout timeout) throws InterruptedException {
     Objects.requireNonNull(timeout, "Timeout cannot be null.");
     return completionLatch.await(timeout.getTimeout(), timeout.getUnit());

diff --git a/src/test/java/blackbox/slow/DefaultPoolIT.java b/src/test/java/blackbox/slow/DefaultPoolIT.java
@@ -21,6 +21,7 @@
 import stormpot.PoolBuilder;
 
 class DefaultPoolIT extends ThreadBasedPoolIT {
+  @Override
   protected PoolBuilder<GenericPoolable> createPoolBuilder(AlloKit.CountingAllocator allocator) {
     return Pool.from(allocator);
   }

diff --git a/src/test/java/docs/MyAllocator.java b/src/test/java/docs/MyAllocator.java
@@ -21,10 +21,12 @@
 import stormpot.Slot;
 
 public class MyAllocator implements Allocator<MyPoolable> {
+  @Override
   public MyPoolable allocate(Slot slot) throws Exception {
     return new MyPoolable(slot);
   }
 
+  @Override
   public void deallocate(MyPoolable poolable) throws Exception {
     // Nothing to do here
     // But it's a perfect place to close sockets, files, etc.

diff --git a/src/test/java/examples/DaoPoolExample.java b/src/test/java/examples/DaoPoolExample.java
@@ -30,8 +30,7 @@
 import java.sql.Statement;
 import java.util.concurrent.TimeUnit;
 
-@SuppressWarnings({"WeakerAccess","unused",
-    "SynchronizationOnLocalVariableOrMethodParameter"})
+@SuppressWarnings({"WeakerAccess","unused"})
 // tag::defineClass[]
 public class DaoPoolExample {
   // end::defineClass[]
@@ -46,6 +45,7 @@ private MyDao(Slot slot, Connection connection) {
     }
     // end::mydaoStart[]
     // tag::mydaoRelease[]
+    @Override
     public void release() {
       slot.release(this);
     }
@@ -79,6 +79,7 @@ public MyDaoAllocator(DataSource dataSource) {
     // end::allocatorStart[]
 
     // tag::allocatorAllocate[]
+    @Override
     public MyDao allocate(Slot slot) throws Exception {
       synchronized (dataSource) {
         return new MyDao(slot, dataSource.getConnection());
@@ -87,6 +88,7 @@ public MyDao allocate(Slot slot) throws Exception {
     // end::allocatorAllocate[]
 
     // tag::allocatorClose[]
+    @Override
     public void deallocate(MyDao poolable) throws Exception {
       poolable.close();
     }

diff --git a/src/test/java/examples/Examples.java b/src/test/java/examples/Examples.java
@@ -134,6 +134,7 @@ public GenericPoolable(Slot slot) {
       this.slot = slot;
     }
 
+    @Override
     public void release() {
       slot.release(this);
     }

diff --git a/src/test/java/stormpot/GenericPoolable.java b/src/test/java/stormpot/GenericPoolable.java
@@ -23,6 +23,7 @@ public GenericPoolable(Slot slot) {
     super(slot);
   }
 
+  @Override
   public void release() {
     lastReleaseBy = Thread.currentThread();
     super.release();