Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky DefaultPoolTest #159

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix flaky DefaultPoolTest #159

merged 1 commit into from
May 27, 2024

Commits on May 27, 2024

  1. Fix flaky DefaultPoolTest 

    The `claimWhenInterruptedMustNotThrowIfObjectIsAvailableViaCache` relies on the thread-local cache having a previously claimed object ready to be reclaimed.
However, background expiration checking would sometimes race and claim the object temporarily, preventing a TLR_CLAIM by the test.
This would cause the test to go down the slow claim path, which is susceptible to interrupts, and which the test was asserting would not happen.
    @chrisvest
    chrisvest committed May 27, 2024
    Configuration menu
    Copy the full SHA
    fcfeedc View commit details
    Browse the repository at this point in the history