Fix pool shrinking with new allocations #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make BAllocThread.reduceSizeByDeallocating() call refill on the disregardPile and the newAllocations. Otherwise, the pool might not be able to deallocate objects allocated but unused prior to a new target size being set. This is normally not a big deal for pools that have any sort of activity, but the `ThreadedPoolTest.decreasingSizeMustNotDeallocateTlrClaimedObjects` test could end up in an infinite loop, and break the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make BAllocThread.reduceSizeByDeallocating() call refill on the disregardPile and the newAllocations. Otherwise, the pool might not be able to deallocate objects allocated but unused prior to a new target size being set. This is normally not a big deal for pools that have any sort of activity, but the
ThreadedPoolTest.decreasingSizeMustNotDeallocateTlrClaimedObjectstest could end up in an infinite loop, and break the build.