Fix flaky ThreadedPoolTest.mustNotHoldOnToDeallocatedObjectsWhenLeakDetectionIsEnabled #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etectionIsEnabled When background expiration checking was enabled, it was possible for the test to race with the background expiration check. This could cause slots to end up in the disregardPile or live queue, instead of the thread-local slot as intended. The disregardPile or live queue would then maintain a strong reference to the object that we were hoping would be deallocated and all references purged, besides the weak reference in the test. The fix is to disable background expiration checking in this test.
It seems to be a common theme that background expiration checking can interfere with tests that expect to be able to TLR claim objects deterministically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When background expiration checking was enabled, it was possible for the test to race with the background expiration check. This could cause slots to end up in the disregardPile or live queue, instead of the thread-local slot as intended. The disregardPile or live queue would then maintain a strong reference to the object that we were hoping would be deallocated and all references purged, besides the weak reference in the test. The fix is to disable background expiration checking in this test.