Upgrade to Java 21 and Remove asciidoclet #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now require Java 21 because of javadoc code snippets, which was the last feature we were really using from Asciidoclet. This also improves javadoc rendering in Intellij, as a side-effect, even though Intellij doesn't know about our snippet path configuration.
The ManagedPool.getAllocationCount is eventually-consistent, and might not have been updated by the time we check. The AlloKit.CountingReallocator increments before the allocated object is available to be claimed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now require Java 21 because of javadoc code snippets, which was the last feature we were really using from Asciidoclet.
This also improves javadoc rendering in Intellij, as a side-effect, even though Intellij doesn't know about our snippet path configuration.