Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Vite builder entry for future SB versions #1155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Feb 12, 2025

As discussed in storybookjs/storybook#30522 (comment), we're going to be removing the slashes from the virtual: path of our Vite builder at some point. This prepares for that change so TurboSnap will continue to work when that happens.

📦 Published PR as canary version: 11.25.3--canary.1155.13295307520.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Feb 12, 2025
@codykaup codykaup self-assigned this Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

📦 Package Size: 5448 KB
✅ Compared to main: 0 KB fa618f5 (5448 KB)

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (fa618f5) to head (f568ce1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files         202      202           
  Lines        7360     7361    +1     
  Branches     1301     1303    +2     
=======================================
+ Hits         5153     5154    +1     
  Misses       2184     2184           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codykaup codykaup force-pushed the cody/cap-2743-did-not-find-any-csf-globs-in-preview-statsjson-after-update branch 2 times, most recently from afca850 to f8b5568 Compare February 12, 2025 17:01
@codykaup codykaup changed the title Add new Vite builder entry for SB 8.5.4 Add new Vite builder entry for future SB versions Feb 12, 2025
@codykaup codykaup force-pushed the cody/cap-2743-did-not-find-any-csf-globs-in-preview-statsjson-after-update branch from f8b5568 to f568ce1 Compare February 12, 2025 21:32
@codykaup codykaup requested a review from a team February 12, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant