Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Storybook 8 #100

Merged
merged 13 commits into from
Mar 25, 2024
Merged

Upgrade to Storybook 8 #100

merged 13 commits into from
Mar 25, 2024

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Jan 19, 2024 •
edited by ghengeveld
Loading

What changed

  • Upgrade to Node 18
  • Upgrade to Storybook 8
  • Update build settings to match latest changes in addon-kit
  • Drop Babel for SWC in example Storybook

Version

Published prerelease version: v2.3.0-next.2

Changelog

🐛 Bug Fix

⚠️ Pushed to next

Authors: 3

📦 Published PR as canary version: 3.0.0--canary.100.fce90b1.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@vanessayuenn vanessayuenn mentioned this pull request Feb 20, 2024
Closed
18 tasks
@ghengeveld ghengeveld marked this pull request as ready for review March 4, 2024 11:54
@ghengeveld ghengeveld added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Mar 4, 2024
@ghengeveld ghengeveld added major Increment the major version when merged and removed patch Increment the patch version when merged skip-release Preserve the current version when merged labels Mar 11, 2024
@ghengeveld ghengeveld self-requested a review March 11, 2024 13:10
@MacroMan MacroMan mentioned this pull request Mar 25, 2024
Closed
@ghengeveld ghengeveld added the release Create a `latest` release when merged label Mar 25, 2024
@ghengeveld ghengeveld merged commit e5e3f07 into main Mar 25, 2024
10 checks passed
@ghengeveld ghengeveld deleted the next branch March 25, 2024 13:11
@MacroMan
Copy link

When can we expect a release please?

@ghengeveld
Copy link
Member

It should've automatically released a new version, but that seems to have failed. I'll take a look at it but that likely won't be today.

@ghengeveld
Copy link
Member

@MacroMan v3.0.0 is released now 👍

wegry
wegry reviewed Mar 29, 2024
View reviewed changes
src/manager/PseudoStateTool.tsx
@@ -1,5 +1,6 @@
import React, { useCallback } from "react"
import { Icons, IconButton, WithTooltip, TooltipLinkList } from "@storybook/components"
Copy link
Contributor

@wegry wegry Mar 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only declaration of Icons? Does this line need updated as well? #111

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegry wegry wegry left review comments

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees
No one assigned
Labels
major Increment the major version when merged release Create a `latest` release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaunEvening @MacroMan @ghengeveld @wegry @JReinhold