Skip to content

Optimized translate function for improved performance #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −7
Open

Optimized translate function for improved performance #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfba52d
Optimized translate function for improved performance
datpmt Feb 26, 2025
428c458
Fix issue1: Bug: Translation not displaying correctly
datpmt Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,24 @@ function decodeHTMLEntities(text) {
}

async function fetchTranslation(caption, translateLang) {
return fetch(`https://api.datpmt.com/api/v1/dictionary/translate?string=${encodeURIComponent(caption)}&to_lang=${translateLang}`)
const baseUrl = `https://translate.googleapis.com/translate_a/t?client=gtx&sl=auto&dt=t&q=${encodeURIComponent(caption)}&tl=${translateLang}`;
return fetch(baseUrl)
.then(response => {
if (!response.ok) {
throw new Error('Translation request failed.');
}
return response.json();
})
.then(data => data)
.then(data => {
const translate = data[0];
return translate;
})
.catch(error => {
throw error;
});
}

updatePopup = function (captionsJson) {
updatePopup = async function (captionsJson) {
const timeElement = pipWindowState.window ? pipWindowState.window.document.getElementById('time') : null;
if (captionsJson == [] || !timeElement) {
return;
Expand All @@ -103,7 +107,7 @@ updatePopup = function (captionsJson) {

// tlang
const translateLang = pipWindowState.window.document.getElementById('translate-lang').value;
fetchTranslation(newCaption, translateLang)
await fetchTranslation(newCaption, translateLang)
.then(translate_caption => {
updateCaption(decodeHTMLEntities(newCaption), decodeHTMLEntities(translate_caption));
})
Expand All @@ -114,9 +118,9 @@ updatePopup = function (captionsJson) {
}
}

updateTimeListener = function () {
updateTimeListener = async function () {
if (captionsJson) {
updatePopup(captionsJson);
await updatePopup(captionsJson);
}
}

Expand Down Expand Up @@ -552,7 +556,7 @@ async function togglePictureInPicture() {
console.log('Pip window created successfully');
setupPipWindowStyles(pipWindow);
await createContent(pipWindow);
video.addEventListener('timeupdate', updateTimeListener);
video.addEventListener('timeupdate', await updateTimeListener);

// Handle window close
pipWindow.addEventListener('pagehide', (event) => {
Expand Down