Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(bootstrap): use is-terminal now in std lib #398

Merged
merged 1 commit into from
Jul 24, 2023
Merged

build(bootstrap): use is-terminal now in std lib #398

merged 1 commit into from
Jul 24, 2023

Conversation

suchapalaver
Copy link
Contributor

@suchapalaver suchapalaver commented Jul 24, 2023 •
edited
Loading

Stabilized in Rust 1.70.0 #hygiene.

PR Checklist

Please complete this checklist after opening your PR

  • I have updated documentation as necessary
  • I have updated helm chart(s) if needed
  • I have added tests if needed
  • All new and existing tests are passing
  • Any breaking changes are clearly flagged and documented
  • I’ve included a link to any relevant ticket(s)

@suchapalaver suchapalaver requested a review from a team as a code owner July 24, 2023 16:05
@vercel vercel bot temporarily deployed to Preview July 24, 2023 16:05 Inactive
@mtbc
Copy link
Contributor

mtbc commented Jul 24, 2023

You probably need to update RUST_VERSION in the unified builder.

@suchapalaver
Copy link
Contributor Author

suchapalaver commented Jul 24, 2023 •
edited
Loading

You probably need to update RUST_VERSION in the unified builder.

Thanks Mark - PR 399 takes care of that.

@suchapalaver suchapalaver force-pushed the fix/use-is-terminal-from-std-library branch from b311f56 to a4177e5 Compare July 24, 2023 17:32
@vercel vercel bot temporarily deployed to Preview July 24, 2023 17:33 Inactive
@suchapalaver suchapalaver merged commit 8bd8f92 into main Jul 24, 2023
3 checks passed
@suchapalaver suchapalaver deleted the fix/use-is-terminal-from-std-library branch July 24, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtbc mtbc mtbc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suchapalaver @mtbc