Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to documentation and insertion of cookbooks #418

Merged
merged 5 commits into from
Nov 20, 2023
Merged

updates to documentation and insertion of cookbooks #418

merged 5 commits into from
Nov 20, 2023

Conversation

ChrisH1066
Copy link
Contributor

@ChrisH1066 ChrisH1066 commented Oct 23, 2023 •
edited
Loading

PR Checklist

Please complete this checklist after opening your PR

  • I have updated documentation as necessary
  • I have updated helm chart(s) if needed
  • I have added tests if needed
  • All new and existing tests are passing
  • Any breaking changes are clearly flagged and documented
  • I’ve included a link to any relevant ticket(s)

@mtbc
Copy link
Contributor

mtbc commented Oct 23, 2023

#416 should fix the cargo-checkmate issues. The DCO failure is that you need the Signed-off-by: bit in your commit message.

@duncanjw duncanjw changed the title updates to documentation and insetion of cookbooks updates to documentation and insertion of cookbooks Nov 15, 2023
duncanjw
duncanjw requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@duncanjw duncanjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing with Sextant should be replaced with Installing with Rancher and either the cookbook stuff pulled into here or at the very least referenced. I prefer the former. Either way we will need to get SUSE to update any cookbook links etc

docs/assets/logos/favicon.png Show resolved Hide resolved
docs: fix versions.txt
e6f1f5d 
Signed-off-by: Duncan Johnston-Watt <[email protected]>
@ryan-s-roberts ryan-s-roberts merged commit 42dc02b into main Nov 20, 2023
4 checks passed
@ryan-s-roberts ryan-s-roberts deleted the fix/updatedocs231023 branch November 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-s-roberts ryan-s-roberts ryan-s-roberts approved these changes

@duncanjw duncanjw duncanjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisH1066 @mtbc @duncanjw @ryan-s-roberts