Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: add mapping to default Core Fluent Bit version #231

Merged
merged 1 commit into from
Nov 22, 2023
Merged

operator: add mapping to default Core Fluent Bit version #231

merged 1 commit into from
Nov 22, 2023

Conversation

patrick-stephens
Copy link
Contributor

Updated scripts to generate the mapping between operator version and default Core Fluent Bit version.

@patrick-stephens patrick-stephens marked this pull request as ready for review November 22, 2023 12:12
tarruda
tarruda approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@tarruda tarruda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but will this script be executed automatically when there are new releases?

@patrick-stephens
Copy link
Contributor Author

patrick-stephens commented Nov 22, 2023 •
edited
Loading

Looks good, but will this script be executed automatically when there are new releases?

Yes, it's also run as a cron job periodically in case things like rate limiting impact it.
Operator invokes it via the existing script in this repo that chains it: https://github.com/calyptia/core-operator/blob/b04b384bca2773a6945738f00f48487197d378cb/.github/workflows/release.yaml#L214

@patrick-stephens patrick-stephens merged commit 7afd9d1 into main Nov 22, 2023
7 checks passed
@patrick-stephens patrick-stephens deleted the add_operator_mapping_core_fb branch November 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarruda tarruda tarruda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-stephens @tarruda