convert: Always convert prom recording rules to Chronosphere recording rules #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarnes52
force-pushed
the
bgb/rmrecordinggroup
branch
from
ed5977b to
9a44e14
Compare
…g rules (not groups)
bbarnes52
force-pushed
the
bgb/rmrecordinggroup
branch
from
9a44e14 to
594a6aa
Compare
prashantv
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if UseDeclarativeTypes is set, prom recording rules are converted to legacy Chronosphere recording groups. Recording rules are preferred over recording groups, which will eventually be deprecated. This PR updates chronoctl convert to always output recording rules.