Convert NaiveDate::from_num_days_from_ce to return Result#1470
Merged
pitdicker merged 1 commit intochronotope:0.5.xfrom Feb 29, 2024
Merged
Convert NaiveDate::from_num_days_from_ce to return Result#1470pitdicker merged 1 commit intochronotope:0.5.xfrom
NaiveDate::from_num_days_from_ce to return Result#1470pitdicker merged 1 commit intochronotope:0.5.xfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1470 +/- ##
==========================================
- Coverage 94.34% 94.34% -0.01%
==========================================
Files 37 37
Lines 17009 17007 -2
==========================================
- Hits 16047 16045 -2
Misses 962 962 ☔ View full report in Codecov by Sentry. |
ba41893 to
c95c67d
Compare
pitdicker
approved these changes
Feb 28, 2024
c95c67d to
bd44d85
Compare
Collaborator
|
It may be for the best that you didn't start with the timestamp methods on |
djc
approved these changes
Feb 29, 2024
Collaborator
|
Your first one in 🎉. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request targets the issue #1469. The implementation is based on the discussion in #1445.
NaiveDate::from_num_days_from_ceto returnResulti32::checked_add()is mapped locally to anErr(Error::OutOfRange)for nowcc @pitdicker