Feat/mushtree and digsite transport

[Chillibloke]

• New file: MagicMushtree.java - Handles all 4 Fossil Island mushtree destinations
• Modified: MountedDigsite.java - Fixed widget-based teleport selection
• Modified: Rs2Walker.java - Added mushtree handling and reachability bypass
• Modified: transports.tsv - Added 12 mushtree routes + Brimhaven dungeon entries

[coderabbitai]

Walkthrough

This pull request introduces Magic Mushtree transport support for Fossil Island, adding a new enum with four destination constants and methods for validating and handling mushtree-based transport interactions. It enhances the crafting guild bank location to recognize crafting capes in the inventory as valid access requirements. The Rs2Walker class is extended to detect Magic Mushtree objects, skip reachability checks for them, and delegate transport handling to the new enum. Additionally, dialogue-based destination selection is now supported for multi-destination teleport items, with a new helper method to identify items requiring dialogue-driven selection. A duplicate getWidget() method in MountedDigsite is refactored to a single location.

Possibly related PRs

• handleInventoryTeleports with specific teleport actions #1571: Modifies Rs2Walker's inventory teleport handling and destination parsing logic, directly intersecting with the new dialogue-based destination selection flow.
• Rs2Walker handleFairyRings improvements #1496: Expands Rs2Walker's transport handling infrastructure, directly related to the Magic Mushtree transport addition.
• 2.0.15 #1541: Modifies Rs2Walker's teleport and pathfinding logic within the same transport handling code paths.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main additions: Magic Mushtree transport support and fixes to Digsite (MountedDigsite) teleportation.
Description check	✅ Passed	The description is directly related to the changeset, listing the new MagicMushtree.java file, modifications to MountedDigsite.java and Rs2Walker.java, and updates to transports.tsv.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.40.5)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/MagicMushtree.java`:
- Around line 76-78: The method in MagicMushtree currently ignores the boolean
result of sleepUntil and always returns true; capture the return value of
sleepUntil (the arrival success) when calling sleepUntil(() ->
Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000) and return that
boolean instead of unconditionally returning true so the method accurately
reflects whether the player arrived.

In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/enums/BankLocation.java`:
- Around line 129-134: The equipped vs inventory cape check is inconsistent:
isWearingCraftingGuild (in BankLocation) only checks
Rs2Equipment.isWearing("crafting cape") but the inventory check includes
"crafting cape(t)"; update the isWearingCraftingGuild boolean to also accept the
trimmed variant by adding Rs2Equipment.isWearing("crafting cape(t)") (or
otherwise normalize/check both "crafting cape" and "crafting cape(t)") so both
equipped and inventory checks treat trimmed crafting capes the same.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Return value ignores whether arrival actually succeeded.

The sleepUntil on line 77 returns a boolean indicating if the player arrived at the destination, but the method returns true unconditionally on line 78. If the 10-second timeout expires without arriving, the method still reports success—inconsistent with the documented contract.

🔧 Proposed fix

         // Wait until we arrive at destination
-        sleepUntil(() -> Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000);
-        return true;
+        return sleepUntil(() -> Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// Wait until we arrive at destination
	sleepUntil(() -> Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000);
	return true;
	// Wait until we arrive at destination
	return sleepUntil(() -> Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000);

🤖 Prompt for AI Agents

In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/MagicMushtree.java`
around lines 76 - 78, The method in MagicMushtree currently ignores the boolean
result of sleepUntil and always returns true; capture the return value of
sleepUntil (the arrival success) when calling sleepUntil(() ->
Rs2Player.getWorldLocation().distanceTo(dest) < OFFSET, 10000) and return that
boolean instead of unconditionally returning true so the method accurately
reflects whether the player arrived.