forked from apache/calcite
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EX…
…CEPT/ARRAY_INTERSECT In Spark Library
- Loading branch information
1 parent
c546d4a
commit ea8c3ca
Showing
4 changed files
with
102 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
core/src/main/java/org/apache/calcite/sql/type/NullOperandTypeChecker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to you under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.calcite.sql.type; | ||
|
||
import org.apache.calcite.sql.SqlCallBinding; | ||
import org.apache.calcite.sql.SqlNode; | ||
import org.apache.calcite.sql.SqlUtil; | ||
|
||
import static org.apache.calcite.util.Static.RESOURCE; | ||
|
||
/** | ||
* Parameter type-checking strategy type must not be a NULL (including <code>NULL</code>, | ||
* <code>CAST(NULL as ...)</code> but not <code>CAST(CAST(NULL as ...) AS ...)</code>). | ||
*/ | ||
public class NullOperandTypeChecker extends SameOperandTypeChecker { | ||
//~ Instance fields -------------------------------------------------------- | ||
|
||
private final boolean allowCast; | ||
|
||
//~ Constructors ----------------------------------------------------------- | ||
|
||
public NullOperandTypeChecker(final int nOperands, final boolean allowCast) { | ||
super(nOperands); | ||
this.allowCast = allowCast; | ||
} | ||
|
||
//~ Methods ---------------------------------------------------------------- | ||
|
||
@Override public boolean checkOperandTypes(final SqlCallBinding callBinding, | ||
final boolean throwOnFailure) { | ||
// all operands can't be null | ||
for (SqlNode node : callBinding.operands()) { | ||
if (SqlUtil.isNullLiteral(node, allowCast)) { | ||
if (throwOnFailure) { | ||
throw callBinding.getValidator().newValidationError(node, RESOURCE.nullIllegal()); | ||
} else { | ||
return false; | ||
} | ||
} | ||
} | ||
return true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters