fix(contract): add event_version to protocol_fee_set event topic #853 - #966
Open
Nwapu-TrustJah wants to merge 1 commit into
Open
fix(contract): add event_version to protocol_fee_set event topic #853#966Nwapu-TrustJah wants to merge 1 commit into
Nwapu-TrustJah wants to merge 1 commit into
Conversation
…nks-labz#853) The protocol_fee_set event was missing event_version(&env) in its topic tuple, which broke indexer filtering consistency. Every other admin-config event includes the version marker. Also adds a test that verifies the event includes the version symbol in its topic. Closes chunks-labz#853 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the
set_protocol_feeevent to includeevent_version(&env)in its topic tuple, consistent with every other admin-config event in the codebase. Theprotocol_fee_setevent was the only event missing the version marker, which broke indexer filtering using versioned event selectors like("protocol_fee_set", 1).Related Issue
Fixes #853
Changes
contracts/predinex/src/lib.rs— addevent_version(&env)to theprotocol_fee_setevent topic tupleVerification Results
Acceptance Criteria
protocol_fee_setevent topic tuple contains exactly two elements