Adding support for path based SVGs #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the library only supports SVGs which have been constructed from shapes. SVGs can also be constructed from paths. If the path attributes are attached to the `svg` element, this data is currently stripped from the sprite, leading to icons which look filled in. This change allows the library to support both filled and path based SVGs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the library only supports SVGs which have been constructed from shapes. SVGs can also be constructed from paths. If the path attributes are attached to the
svgelement, this data is currently stripped from the sprite, leading to icons which look filled in. This change allows the library to support both filled and path based SVGs.