test-cases: Don't treat SKIP as an error

test-cases was incorrectly treating skipped unit tests as tests that had failed, or rather tests that had not run. This resulted in skipped unit tests failing the travis build, which is not really what we wanted. Fixes #296 Signed-off-by: Mark Ryan <[email protected]>
ciao-project · Jun 21, 2016 · cd02015 · cd02015
1 parent 6cc6aea
commit cd02015
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test-cases/test-cases.go b/test-cases/test-cases.go
@@ -149,7 +149,7 @@ func init() {
 	flag.StringVar(&coverProfile, "coverprofile", "", "Path of coverage profile to be generated")
 	flag.BoolVar(&appendProfile, "append-profile", false, "Append generated coverage profiles an existing file")
 	flag.BoolVar(&colour, "colour", true, "If true failed tests are coloured red in text mode")
-	resultRegexp = regexp.MustCompile(`--- (FAIL|PASS): ([^\s]+) \(([^\)]+)\)`)
+	resultRegexp = regexp.MustCompile(`--- (FAIL|PASS|SKIP): ([^\s]+) \(([^\)]+)\)`)
 	coverageRegexp = regexp.MustCompile(`^coverage: ([^\s]+)`)
 }
 
@@ -335,7 +335,7 @@ func runPackageTests(p *PackageTests, coverFile string, errorOutput *bytes.Buffe
 			exitCode = 1
 		} else {
 			t.Result = res.result
-			t.Pass = res.result == "PASS"
+			t.Pass = (res.result == "PASS" || res.result == "SKIP")
 			if !t.Pass {
 				exitCode = 1
 			}