Bypass Fa3 autism :( #11
Conversation
|
Thanks for this PR, but there are a couple crucial issues with it.
|
| @@ -236,22 +237,21 @@ async def request(self, route: Route, **kwargs) -> Any: | |||
| f"Making request to {route.method} {url}. headers: {headers}, params: {kwargs.get('params', None)}, json: {kwargs.get('json', None)}" | |||
| ) | |||
| try: | |||
| res = await self.__session.request( | |||
| res = await requests_ORI.AsyncSession().request( | |||
There was a problem hiding this comment.
Just like with aiohttp, the session should be reused and stored, not creating a new one
| route.method, | ||
| url | ||
| if self.whitelisted is True |
There was a problem hiding this comment.
If you're going to remove generating the url like this, you should also remove HTTPClient.whitelisted, and the others. kick.Client's docstring would also need to change
| @@ -4,12 +4,13 @@ | |||
| import json | |||
| import logging | |||
| from typing import TYPE_CHECKING, Any, Coroutine, Optional, TypeVar, Union | |||
| from curl_cffi import requests as requests_ORI | |||
There was a problem hiding this comment.
There is no reason to change the name its imported under. Importing curl_cffi itself is better than changing the name of something from the library
|
@cibere I hope you enjoy the fact that I really like this repo. Yes its really trashy , but it does work , I promise you I tried, I am able to connect , I am able to get the Fa3 corrected I am not a developer , and my english is too broken to become one too |
I just can't put this in the main repo in the state its in. Though once I'm home from camping I can probably fix it. |
Oh no this was not a request to pull , I just showed you can use curl_cffi Yes you're right its a really put in thing , for me it works flawlessly , but I guess you can just to show anyways if you can get this cffi thing into an aio libary it would be amazing .. its a way that works, but it breaks anything else - but shout out for you for this kick.py thing https://github.com/yifeikong/curl_cffi/blob/master/curl_cffi/aio.py god knows what its all about , should be there it is a library , but I have no idea what the hell they do cffi is something that cross do C and python idk man it does act like requests tho |
|
@cibere im unsure if curl_cffi works too well on windows |
Oh? What operating systems did you test it on? |
arch linux because I am an hipster |
|
bump |
thanks use curl_cffi