Skip to content

Commit

Permalink
Update @tsconfig/ember & fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mkszepp committed Jan 15, 2024
1 parent 0bdf36e commit 2f5c532
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion ember-basic-dropdown/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@rollup/plugin-babel": "^6.0.4",
"@tsconfig/ember": "^2.0.0",
"@tsconfig/ember": "^3.0.3",
"@types/ember": "^4.0.10",
"@types/ember__application": "^4.0.10",
"@types/ember__array": "^4.0.9",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import hasMoved from '../utils/has-moved.ts';
import { isTesting } from '@embroider/macros';
import { modifier } from 'ember-modifier';
import { Dropdown } from './basic-dropdown.ts';
import type { Dropdown } from './basic-dropdown.ts';

export interface BasicDropdownContentSignature {
Element: Element;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Component from '@glimmer/component';
import { action } from '@ember/object';
import { Dropdown } from './basic-dropdown';
import type { Dropdown } from './basic-dropdown';

interface BasicDropdownSignature {
Element: Element;
Expand Down
5 changes: 3 additions & 2 deletions ember-basic-dropdown/src/components/basic-dropdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@ import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object';
import { guidFor } from '@ember/object/internals';
import calculatePosition, {
import calculatePosition from '../utils/calculate-position.ts';
import type {
CalculatePosition,
CalculatePositionResult,
} from '../utils/calculate-position.ts';
import { schedule } from '@ember/runloop';
import { macroCondition, isTesting } from '@embroider/macros';
import config from 'ember-get-config';
import type Owner from '@ember/owner';
import { ComponentLike } from '@glint/template';
import type { ComponentLike } from '@glint/template';

export interface DropdownActions {
toggle: (e?: Event) => void;
Expand Down
5 changes: 3 additions & 2 deletions ember-basic-dropdown/src/modifiers/basic-dropdown-trigger.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import Modifier, { ArgsFor, PositionalArgs, NamedArgs } from 'ember-modifier';
import Modifier from 'ember-modifier';
import type { ArgsFor, PositionalArgs, NamedArgs } from 'ember-modifier';
import { assert } from '@ember/debug';
import { action } from '@ember/object';
import { isDestroyed, registerDestructor } from '@ember/destroyable';
import hasMoved from '../utils/has-moved.ts';
import { Dropdown } from '../components/basic-dropdown';
import type { Dropdown } from '../components/basic-dropdown';
import type Owner from '@ember/owner';

interface Signature {
Expand Down
8 changes: 2 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2f5c532

Please sign in to comment.