Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to v2 addon #728

Merged
merged 38 commits into from
Jan 2, 2024
Merged

Switch to v2 addon #728

merged 38 commits into from
Jan 2, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Nov 27, 2023

  • BRAKING: move addon to v2 (embroider / ember-auto-import v2 is now required)
  • BRAKING: there is necessary to add <BasicDropdownWormhole /> manually in application.hbs, because contentFor doesn't exists for an v2 addon see installation guide
  • BRAKING: css import must be done manually (this is only braking for apps which are not using less/scss see installation guide
  • BRAKING: For less there is necessary to add import path in ember-cli-build see installation guide
  • ENHANCEMENT: Add missing properties to interface
  • INTERNAL: switch from npm to pnpm

@mkszepp mkszepp changed the title [WIP] Switch to v2 addon, use pnpm & fix typescript [WIP] Switch to v2 addon, use pnpm & improve typescript Nov 27, 2023
@mkszepp mkszepp mentioned this pull request Dec 5, 2023
@mkszepp mkszepp changed the title [WIP] Switch to v2 addon, use pnpm & improve typescript Switch to v2 addon, use pnpm & improve typescript Dec 5, 2023
@mkszepp mkszepp changed the title Switch to v2 addon, use pnpm & improve typescript Switch to v2 addon Dec 22, 2023
@mkszepp mkszepp merged commit 24e3d8f into cibernox:master Jan 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant