Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract make_quantiles from convert_to_output #352

Closed
2 of 3 tasks
djinnome opened this issue Aug 17, 2023 · 0 comments · Fixed by #353
Closed
2 of 3 tasks

Refactor: extract make_quantiles from convert_to_output #352

djinnome opened this issue Aug 17, 2023 · 0 comments · Fixed by #353
Assignees

Comments

@djinnome
Copy link
Contributor

djinnome commented Aug 17, 2023

convert_to_output is getting a bit unwieldy, and in the course of providing ensemble outputs for the covid19forecastinghub, we found a need to extract the section of the code that computes quantiles into its own function make_quantiles.

Rather than include that code in the sa_ensemble_eval branch, we are separating out that code into its own branch and PR.

This branch will:

  • Extract make_quantiles from convert_to_output
  • Create a unit test for make_quantiles using dummy data where we know the quantiles.
  • Serve as the basis for a future PR where we compute the fluxes in a post-processing step as part of convert_to_output
@djinnome djinnome linked a pull request Aug 17, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants