Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted make_quantiles from convert_to_output #353

Merged

Conversation

djinnome
Copy link
Contributor

@djinnome djinnome commented Aug 17, 2023

@djinnome djinnome self-assigned this Aug 17, 2023
@djinnome djinnome linked an issue Aug 17, 2023 that may be closed by this pull request
3 tasks
@anirban-chaudhuri anirban-chaudhuri self-assigned this Aug 23, 2023
@anirban-chaudhuri anirban-chaudhuri added awaiting review PR submitter awaiting code review from reviewer integration Tasks for integration with TA4 labels Aug 24, 2023
Copy link
Contributor

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SamWitty SamWitty merged commit 18250b8 into main Aug 24, 2023
3 checks passed
@anirban-chaudhuri anirban-chaudhuri deleted the 352-refactor-extract-make_quantiles-from-convert_to_output branch August 25, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer integration Tasks for integration with TA4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: extract make_quantiles from convert_to_output
3 participants