Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrate does not seem to work when data is mapped to observables #439

Closed
sabinala opened this issue Dec 20, 2023 · 2 comments · Fixed by #450
Closed

Calibrate does not seem to work when data is mapped to observables #439

sabinala opened this issue Dec 20, 2023 · 2 comments · Fixed by #450
Assignees
Labels
bug Something isn't working

Comments

@sabinala
Copy link
Contributor

Calibrate works fine when columns in a given dataset are mapped to state variables (like "I" or "H"), but fails when data columns are mapped to observables (like "infected" or "hospitalized"). Please see https://github.com/ciemss/pyciemss/blob/sa-load-data-tests/docs/source/sa-testing-notebooks/tests_for_load_data.ipynb for example.

@sabinala sabinala added the bug Something isn't working label Dec 20, 2023
@SamWitty
Copy link
Contributor

SamWitty commented Jan 3, 2024

@sabinala , could you please add a (currently failing) test to https://github.com/ciemss/pyciemss/blob/main/tests/test_interfaces.py that summarized the issue you're encountering? While making this PR, please add @pytest.skip so that the tests still "pass", even though one of them should fail. I (or someone else) will then follow up in a subsequent PR with a fix.

@sabinala
Copy link
Contributor Author

sabinala commented Jan 8, 2024

I created more specific issue #447 to address the erroneous suffixes being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants