Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarifying calibrate failure for data mapped to observables #516

Closed
wants to merge 1 commit into from
Closed

clarifying calibrate failure for data mapped to observables #516

wants to merge 1 commit into from

Conversation

sabinala
Copy link
Contributor

@sabinala sabinala commented Mar 5, 2024

This PR separates the pytest.skip statement so that it is clear that calibrate tests fail when data is mapped to observables. See Issue #492

@sabinala sabinala linked an issue Mar 5, 2024 that may be closed by this pull request
KeyError in calibrate when data is mapped to observables #492
Closed
@sabinala sabinala requested a review from SamWitty March 5, 2024 19:34
@sabinala sabinala added the awaiting review PR submitter awaiting code review from reviewer label Mar 5, 2024
@sabinala
Copy link
Contributor Author

sabinala commented Mar 5, 2024 •
edited
Loading

@SamWitty let me know if you have questions about this. This issue had been brought up before (#439), but it was closed with PR #450. At the time, we thought the problem was Issue #447. That issue has been fixed, but we're still not able to calibrate to observables.

@SamWitty SamWitty mentioned this pull request Mar 6, 2024
Merged
@SamWitty SamWitty closed this Mar 6, 2024
@SamWitty
Copy link
Contributor

SamWitty commented Mar 6, 2024

Subsumed by #517

@sabinala sabinala deleted the 492-keyerror-in-calibrate-when-data-is-mapped-to-observables branch March 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWitty SamWitty Awaiting requested review from SamWitty

Assignees
No one assigned
Labels
awaiting review PR submitter awaiting code review from reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError in calibrate when data is mapped to observables
2 participants
@sabinala @SamWitty