Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled Normal Noise Model #247

Merged
merged 16 commits into from
Jul 14, 2023
Merged

Conversation

SamWitty
Copy link
Contributor

This PR addresses an error when conditioning on data using the ScaledBeta noise model.

@SamWitty SamWitty added bug Something isn't working WIP PR submitter still making changes, not ready for review integration Tasks for integration with TA4 labels Jul 13, 2023
@SamWitty SamWitty marked this pull request as draft July 13, 2023 19:10
@SamWitty SamWitty marked this pull request as ready for review July 13, 2023 20:46
@SamWitty SamWitty added awaiting review PR submitter awaiting code review from reviewer and removed WIP PR submitter still making changes, not ready for review labels Jul 14, 2023
Copy link
Contributor

@anirban-chaudhuri anirban-chaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaled Normal implementation now looks good to me.
However, I had a couple of other comments:

  • When the observation is 0, should the observation model use the scaled normal by default? If so, it could be added in the if-statement that currently exists.
  • Otherwise, an observation of 0 will lead the scaled beta distribution to have alpha=0, which will not work. Am I understanding it correctly that you are setting alpha=scaled_mean * pseudocount and beta=(1 - scaled_mean) * pseudocount for the beta distribution (or, I might be misunderstanding the pytorch description for the inputs)?

Copy link
Contributor

@anirban-chaudhuri anirban-chaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Issues we might need to revisit:

  • Scaled beta distribution for very high and very low values of alpha and beta parameters for Beta distribution
  • Truncated distribution instead of Scaled Normal to avoid negative values and values greater than total population for states in covid models

@anirban-chaudhuri anirban-chaudhuri merged commit d8693ea into main Jul 14, 2023
3 checks passed
@anirban-chaudhuri anirban-chaudhuri deleted the sw-alternative-noise-model branch July 14, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer bug Something isn't working integration Tasks for integration with TA4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants