-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaled Normal Noise Model #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWitty
added
bug
Something isn't working
WIP
PR submitter still making changes, not ready for review
integration
Tasks for integration with TA4
labels
Jul 13, 2023
SamWitty
added
awaiting review
PR submitter awaiting code review from reviewer
and removed
WIP
PR submitter still making changes, not ready for review
labels
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scaled Normal implementation now looks good to me.
However, I had a couple of other comments:
- When the observation is 0, should the observation model use the scaled normal by default? If so, it could be added in the if-statement that currently exists.
- Otherwise, an observation of 0 will lead the scaled beta distribution to have alpha=0, which will not work. Am I understanding it correctly that you are setting
alpha=scaled_mean * pseudocount
andbeta=(1 - scaled_mean) * pseudocount
for the beta distribution (or, I might be misunderstanding the pytorch description for the inputs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Issues we might need to revisit:
- Scaled beta distribution for very high and very low values of alpha and beta parameters for Beta distribution
- Truncated distribution instead of Scaled Normal to avoid negative values and values greater than total population for states in covid models
anirban-chaudhuri
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting review
PR submitter awaiting code review from reviewer
bug
Something isn't working
integration
Tasks for integration with TA4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an error when conditioning on data using the
ScaledBeta
noise model.