Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

283 july evaluation scenario 3 #311

Closed
wants to merge 43 commits into from
Closed

Conversation

djinnome
Copy link
Contributor

@akruel01 is still experiencing issues with loading in mira models with ControlledProduction

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@djinnome djinnome assigned djinnome and akruel01 and unassigned djinnome Jul 31, 2023
@djinnome djinnome requested a review from SamWitty August 6, 2023 05:48
@djinnome djinnome added WIP PR submitter still making changes, not ready for review awaiting review PR submitter awaiting code review from reviewer and removed WIP PR submitter still making changes, not ready for review labels Aug 6, 2023
djinnome and others added 6 commits August 8, 2023 13:49
* 293 enable an all but option on trajectory plot (#303)

* Changed to 'keep' and 'drop' instead of 'subset'

* Updating docstring and error messages for 'keep'

* Updating example notebooks for 'keep' and 'drop' instead of 'subset

* Changing 'subset' to 'keep'

* 317 odd behavior when plotting data (#322)

* creating a notebook to illustrate an issue with Vega plot

* FIX: Exemplar points used to be all connected.

Added tests for some common schema issues.

* Fixed example in notebook

---------

Co-authored-by: sabinala <[email protected]>
Co-authored-by: Joseph Cottam <[email protected]>

---------

Co-authored-by: Joseph Cottam <[email protected]>
Co-authored-by: sabinala <[email protected]>
Co-authored-by: Joseph Cottam <[email protected]>
@djinnome djinnome added WIP PR submitter still making changes, not ready for review and removed awaiting review PR submitter awaiting code review from reviewer labels Aug 15, 2023
@djinnome
Copy link
Contributor Author

djinnome commented Aug 15, 2023

Per @SamWitty we will attempt to break this PR into smaller pieces.

Logically, it can be broken into these chunks:

@SamWitty SamWitty closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR submitter still making changes, not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants