Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visuals rearrange #320

Merged
merged 22 commits into from
Aug 15, 2023
Merged

Visuals rearrange #320

merged 22 commits into from
Aug 15, 2023

Conversation

JosephCottam
Copy link
Contributor

Make the visualization code more maintainable by splitting it into parts.

General principles:

  • Each category of plot is in its own file.
  • Schemas are in a separate directory.
  • Anytime you need to know you are working with vega, it goes in 'vega.py'
  • plots.py re-exports the main plot types and utilities for manipulating plots in-general.

Users should be able to import plots and access most of what they need. Utilities related to specific plot types are segregated into their own files. This makes it easier to identify 'dead code' and do custom data-preprocessing for a broad category of plots without introducing incidental code sharing between plot types.

@JosephCottam JosephCottam added the WIP PR submitter still making changes, not ready for review label Aug 7, 2023
@JosephCottam JosephCottam self-assigned this Aug 7, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JosephCottam
Copy link
Contributor Author

This structure was in-part a reaction to difficulties encountered while introducing some network/graph type layouts. (So those are included in this PR as well.)

@JosephCottam JosephCottam added awaiting review PR submitter awaiting code review from reviewer and removed WIP PR submitter still making changes, not ready for review labels Aug 9, 2023
@JosephCottam
Copy link
Contributor Author

@marjoleinpnnl I manually merged to the (1) select-exemplar-trajectories, (2) save PNG and (3) click-highlight-legend.

Can you add some tests for the the "select-exemplar traces" and "save PNG"? They can add to test_plots OR you extract out the trajectory tests into a test_trajectories. Either make sense to me.

Copy link
Contributor

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through the notebooks and reviewed all the files.

Looks good to me. Thanks @JosephCottam and @marjoleinpnnl for creating such nice visualization tools for us.

@djinnome djinnome merged commit 78141de into main Aug 15, 2023
3 checks passed
SamWitty pushed a commit that referenced this pull request Aug 24, 2023
* Spring force graph layout and example data.

* Marks-nesting of nodes.

* Mode reprsented as dounut chart showing attribution sources

* Link weight attribution WIP

* WIP: First draft rainbow edges

Actual offset/overlap varies by angle, but it exists.

* Layering and size-relationships improved.

* Node labels

* Multigraph visual added to the the plots module

* Color domain includes links.  Color legend added.

* Braking apart plots for more clear grouping of functions.

* Spring-graph: Label on top of nodes

* Mouse manipulation on multi-graph.

* Balanced stacking of edges.

* Parallel line equation
PROBLEM: alternate lines collapse around the NW/SE diagonal

* Multigraph working in all orientations (BUT slot is wrong...)
Mulitgraph working at all angular orientations

* Visual schema facet-check handes post-facet transformation.  Added legend to spring-graph

* Initial capability to save PNG.

* ipy_display produces a png by default.

Can do PNG, SVG or interactive.

* Highlight legend on chart-click

* Select exemplar trajectories by characteristics.
@JosephCottam JosephCottam deleted the Visuals-rearrange branch August 29, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR submitter awaiting code review from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants