325 april ensemble examples not longer work #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with multiple simulatino sources, the 'sample_id' was needed in addition to the timestamp to ensure uniqueness. The visualizations still work with the extended index.
JosephCottam
added
the
WIP
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sabinala
added
awaiting review
|
@sabinala or @JosephCottam resolve the conflicts? |
|
@djinnome same here, I think this is a depricated issue. We're doing something different to generate synthetic data for testing model calibration. I recommend deleting this issue. Let me know if you think differently. |
|
Closing this PR without merge (and the corresponding issue) based on @sabinala 's guidance above. Please reopen if you believe this is a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.