-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting "big box" and "little box" interfaces apart (attempt #2) #384
Conversation
@SamWitty The failures on these tests occur on my own machine, but only sometimes. Can you look and let me know if I did something wrong in my translation to small-box interfaces? |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@SamWitty I have the notebooks executing with the exception of one cell. Here are notes on the choices I made:
Depending on how important these things are to you (esp. 2 and 3), this might be ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are a few minor refactors I'd like to make, but I'll add those as a separate PR.
Moves the big-box interfaces into their own module and deprecates them.