Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petri graph layout clean new branch #391

Merged
merged 19 commits into from
Nov 1, 2023

Conversation

marjoleinpnnl
Copy link
Contributor

Merges jc-graph-refinments with Petri graph with fixed layout with update so it keeps all moved nodes in a fixed position and double clicking unfixes the node. Petri graph is viewable in notebook/visual examples/Graphs.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@JosephCottam JosephCottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests.
Changed variable names in the graph schema to clarify their role.
Removed a toggle in the schema whose action was hard to understand and whose purpose was difficult to imagine beyond testing.

@JosephCottam JosephCottam merged commit 1c37f55 into main Nov 1, 2023
1 of 3 checks passed
@JosephCottam JosephCottam deleted the petri_graph_layout_clean_new_branch branch November 1, 2023 23:39
@SamWitty
Copy link
Contributor

@JosephCottam and @marjoleinpnnl , I'm going to revert this PR and restore the branch because of the conflicts with the major refactor going on in staging-refactor. I'm mostly doing this so that the work great work here doesn't get omitted from the next version of PyCIEMSS. I should have the staging branch merged in very soon, so hopefully this wont need to hand for long.

@SamWitty SamWitty restored the petri_graph_layout_clean_new_branch branch December 15, 2023 18:25
SamWitty added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants