Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

448 create synthetic data to sanity check results from calibrate #452

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

sabinala
Copy link
Contributor

This PR adds a notebook wherein a model is calibrated to synthetic data generated by adding noise to a sample of that model in order to test calibration accuracy.

Closes #448

@sabinala sabinala added the WIP PR submitter still making changes, not ready for review label Jan 10, 2024
@sabinala sabinala self-assigned this Jan 10, 2024
@sabinala sabinala linked an issue Jan 10, 2024 that may be closed by this pull request
4 tasks
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SamWitty
Copy link
Contributor

@sabinala , what is the current status of this PR?

@sabinala
Copy link
Contributor Author

@SamWitty the current status of this PR is that calibrate fails when using synthetic data, and I'm getting an error message in this notebook (https://github.com/ciemss/pyciemss/blob/448-create-synthetic-data-to-sanity-check-results-from-calibrate/docs/source/synthesize_data_to_test_calibrate.ipynb). Was planning to have @ShantMahserejian take a look at it later today...will make an issue with the error message if we can't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR submitter still making changes, not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create synthetic data to sanity check results from calibrate
2 participants